[Editor UI] Change "rename" to "change source" for images

Pharan

Nate, I remember you describing switching/resolving the image source was possible and I just tried it today. If I hadn't known it was there, I would've been spending more time realigning and redoing things. That's happened to me already and it was not pleasant. XD

The labels and button that describes the function use terms like "rename" and "name".

For clarity, my vote is to make the button (and any future ways to reach the same functionality) read something like "change image source" or "change source" or "replace source" or "replace" instead of "rename"; "name" is a misnomer for a field that points to a file/image source.

I guess the future image chooser and its related UI changes might solve this... or not.

Pharan

Nate

The name is only a path for region attachments. Even then, at runtime the name can be used to look up a region in a texture atlas or do anything else (render an SVG, load a file from disk, fetch a URL, etc). At runtime it is definitely a name. In the editor it could say "Change Path" instead of "Rename" for region attachments, though this creates a minor mismatch since it is a name in the runtimes. For other attachments (eg a bounding box) it would be a name.

Pharan

Ah, of course. I only meant in the case of attached images. Bones names and slot names (and i guess bounding box names) are still just names.

But in all those image cases (svg, file from disk, region in an atlas, url), it would arguably be better called a "source" or "path" instead of a "name", at least on the buttons and labels in the editor.

I realized while I was writing this that you might have actually just overloaded that field in the JSON to mean different things for different types of objects. And I understand it's hard to change something so fundamental in the JSON spec at this point.

But I would hate for Spine to be one of those programs where you have to look up a manual to find out about Editor functionality like this because of some naming quirk in the runtime and file spec. ;___;

Nate

The attachment name is overloaded in both the JSON and runtimes (and UI :p). All attachments have a name, for region attachments it is often used as a path. "source" is a bit vague, "path" isn't too bad too use in the UI, since the name is always a path relative to the image directory in the UI.
https://trello.com/card/set-path-instea ... c0059d9/80

Pharan

Oh yeah. Pretty minor, but on the same thread:
There's a bug where the "duplicate" button isn't disabled when you have an image/region attachment selected.
What it does doesn't make sense. I think its behavior when it's a child of a skin attachment is what you intended.

Nate

You're right. Changed the duplicate button. Not sure it is useful, but it only works on skin attachments now.