Issue moving the character when updating the camera

kyanno

I'm having an issue updating my character position when I call both updateCamera() and setting the projection matrix of spritebatch.
When update camera is called my character doesn't seem to be in the correct position(zooming along faster than her bounding box).
Setting the projection matrix of spriteBatch to cam.combined she doesn't appear on screen at all. Is there something I'm doing wrong here?

The problem code is within the render() method.

public class LevelRenderer {
	
private static final float CAMERA_WIDTH = 10f;
private static final float CAMERA_HEIGHT = 7f;

private LevelTwo level;
private OrthographicCamera cam;

//debug rendering
ShapeRenderer debugRenderer = new ShapeRenderer();

private TextureRegion anaFrame;

ShapeRenderer renderer;
Skeleton skeleton;
SkeletonJson json;
SkeletonRenderer skelRend;
Animation runAnimation;
Bone root;
private SpriteBatch spriteBatch;
private boolean debug = true;
private int width;
private int height;
private float ppuX;
private float ppuY;
private Ana ana;
float time;
Array<Event> events = new Array();

public void setSize (int w, int h){
	this.width = w;
	this.height = h;
	ppuX = (float)width / CAMERA_WIDTH;
	ppuY = (float)height / CAMERA_HEIGHT;
	loadTextures();
}

public LevelRenderer(LevelTwo level, boolean debug){
	this.level = level;
	ana = level.getAna();
	this.cam = new OrthographicCamera(CAMERA_WIDTH, CAMERA_HEIGHT);
	this.cam.position.set(CAMERA_WIDTH / 2f, CAMERA_HEIGHT / 2f, 0);
	this.cam.update();
	this.debug = debug;
	spriteBatch = new SpriteBatch();
	
}

private void loadTextures(){
	TextureAtlas atlas = new TextureAtlas(Gdx.files.internal("images/Ana.atlas"));
	json = new SkeletonJson(atlas);
	json.setScale(ppuY/665.0f);
	SkeletonData skeletonData = json.readSkeletonData(Gdx.files.internal("images/Ana.json"));
	skeleton = new Skeleton(skeletonData);
	runAnimation = skeletonData.findAnimation("run");
	root = skeleton.getRootBone();
	skeleton.updateWorldTransform();
	skelRend = new SkeletonRenderer();
}

public void render(){
	updateCamera(ana.getPosition().x, CAMERA_HEIGHT / 2);
	spriteBatch.setProjectionMatrix(cam.combined);
	spriteBatch.begin();
	drawAna();
	spriteBatch.end();
	skeleton.updateWorldTransform();
	if(debug)
		drawDebug();
}

private void updateCamera(float x, float y){
	if(ana.getPosition().x > CAMERA_WIDTH / 2 || ana.getPosition().x < CAMERA_WIDTH / 2){
		cam.position.set(x, y, 0);
		cam.update();
	}
}

private void drawAna(){
	float lastTime = time;
	time += Gdx.graphics.getDeltaTime();
	
	events.clear();
	if (ana.getState() == State.WALKING)
		runAnimation.apply(skeleton, lastTime, time, true, events);
	else
		skeleton.setBonesToSetupPose();
	
	root.setX(ana.getPosition().x * ppuX);
	if(ana.getFacingLeft() == false)
	{
		root.setX(-1 * (ana.getPosition().x * ppuX));
	}
	root.setY(ana.getPosition().y * ppuY);
	skeleton.setFlipX(!ana.getFacingLeft());
	skelRend.draw(spriteBatch, skeleton);
	
}

private void drawDebug(){
	debugRenderer.setProjectionMatrix(cam.combined);
	debugRenderer.begin(ShapeType.Line);
	
	for(Block block : level.getBlocks()){
		Rectangle rect = block.getBounds();
		float x1 = block.getPosition().x + rect.x;
		float y1 = block.getPosition().y + rect.y;
		debugRenderer.setColor(new Color(1, 0, 0, 1));
		debugRenderer.rect(x1, y1, rect.width, rect.height);
	}
	Rectangle rect = ana.getBounds();
	float x1 = ana.getPosition().x;
	float y1 = ana.getPosition().y;
	debugRenderer.setColor(new Color(0, 1, 0, 1));
	debugRenderer.rect(x1 - (rect.width/2), y1, rect.width, rect.height);
	debugRenderer.end();
}



}

Nate

Use skeleton x/y to position the skeleton. When you flip it flips the root bone around 0,0.

You probably want to use AnimationState, it is much easier than using Animation directly.

When you set the skeleton position I'm not sure you want to use ppuX/Y. I'd expect you to position your stuff using the coordinates of the camera.

kyanno

Thanks for the tips. I was under the impression the root bone should be used to position a skeleton around the screen. I switched it up in my code.
The reason I used ppuX was because the spriteBatch projection matrix wasn't combined with the camera. I forgot to remove that part when pasting the code, but you're correct it should be the camera coordinates. That fixed her positioning problems.

When I apply those fixes there is still one remaining issue though:
When I combine the spritebatch matrix with the camera, my character isn't scaled correctly anymore. (Her foot is as big as the entire screen)
Is there something I need to do after this? Such as update her world transform?

Nate

Set the scale on the SkeletonJson. This scales the size in Spine with the size in your camera's coordinate system.

kyanno

I've got that set up already.
json.setScale(ppuY/665.0f);
This value equates to a scale factor of roughly 0.1
It is in fact scaling because if I comment that line out she is even bigger.

I tested a different value of 0.0015 which seemed to scale correctly. I tried using that as a scale factor and made ppuY/45714.287
This works for a resolution of 800x480, but it doesn't for any other resolution I specify. Whereas without combining the spritebatch matrices I can specify any resolution I want (using ppuY/665) and she is correctly scaled to 1 camera unit high.

kyanno

I got it to work! 😃 I just had to scale it by the constant factor of 0.0015 and it seems to work now with any resolution. Thanks again for your help nate